Feature: Terrain Preview and simple Elevation Query #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acalcutt
reviewed
Dec 21, 2024
acalcutt
reviewed
Dec 21, 2024
Co-authored-by: Andrew Calcutt <[email protected]>
acalcutt
reviewed
Dec 22, 2024
acalcutt
reviewed
Dec 22, 2024
acalcutt
reviewed
Dec 22, 2024
Co-authored-by: Andrew Calcutt <[email protected]>
|
Thanks for all suggestions so far. I did a local build and converted my terrain mbtile source to a pmtile and both are working so far :) |
acalcutt
reviewed
Dec 28, 2024
acalcutt
approved these changes
Jan 2, 2025
|
I was noticing how long some of the decimal point values are. I wonder if we should add a limit to the number of decimal places, maybe something like 7 |
|
@acalcutt: That should be no problem, but at least for lat/long (float-url) the values are the same as the input, which are taken from leaflet click event. For x/y the values are calculated. Or should we only limit the display in the preview? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
Both require configured encoding (see config.rst).
In general this adds just some eye candy and an "inspect" function for terrain like the geojson endpoint.